Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXCHANGE] Use CHECK_ASSET_IN_NO_DISPLAY instead of CHECK_ASSET_IN #8008

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sprohaszka-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace the use of CHECK_ASSET_IN value by CHECK_ASSET_IN_NO_DISPLAY value in checkPayoutAddress call in SELL and FUND (legacy and NG) workflow.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Oct 4, 2024
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 8:47am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 4, 2024 8:47am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 4, 2024 8:47am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2024 8:47am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2024 8:47am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant