fix: slack-notify cli #51
Conversation
|
I should've done TDD 🙄 |
| @@ -248,8 +248,8 @@ type channel_obj = { | |||
| creator: user; | |||
| is_archived: bool; | |||
| is_general: bool; | |||
| name_normalized: string; | |||
There was a problem hiding this comment.
I guess conversations.list returns a conversation and not a channel_obj, so this needs to be updated somehow.
There was a problem hiding this comment.
It returns "a list of limited channel-like conversation objects".
There was a problem hiding this comment.
In such case I suggest renaming it to conversation_obj since the Slack API calls it the "conversation type".
I think in this case the API breakage is happening anyway so might as well stick to the naming that Slack uses so it is easier to understand.
There was a problem hiding this comment.
Looks like channels.* API was superseded along with im.* and others by conversations.*. However, there are still channel, group, im, mpim API object types, that are different from conversation type. The codebase also has a conversation type, which is not the type for the conversation API object. It seems instead of attempting a fix to the notify CLI tool now, we need to overhaul the underlying types first.
There was a problem hiding this comment.
This is now built on #52 which provides a new conversation_obj type. I'm not sure about the types of id this new API can have though.
fix: conversations.list api
channels.listseems to becomeconversations.listnow.conversations.listare limited conversation objects that do not havemembersattribute.