Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring round 1 #271

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

NikolajSchlej
Copy link
Collaborator

…r compressed items

- remove unused code to support Qt 5.5 and earlier Qt versions
- remove unused section parsing code
- add a check and description for section alignment quirk (compiled out for now)
@NikolajSchlej
Copy link
Collaborator Author

NikolajSchlej commented Aug 24, 2022

Coverity failure is unrelated, but requires separate investigation and possible update to its action:

Attempting to build UEFITool NE for mac...
[22](https://github.com/LongSoft/UEFITool/runs/8003647161?check_suite_focus=true#step:4:23)
Building UEFITool A60
[23](https://github.com/LongSoft/UEFITool/runs/8003647161?check_suite_focus=true#step:4:24)
Project ERROR: Xcode is not installed in /Applications/Xcode_13.2.1.app/Contents/Developer. Please use xcode-select to choose Xcode installation path.
[24](https://github.com/LongSoft/UEFITool/runs/8003647161?check_suite_focus=true#step:4:25)
Error: Process completed with exit code 1.

UPD: this should be fixed now.

@NikolajSchlej
Copy link
Collaborator Author

New actions to fix #150
actions

@NikolajSchlej
Copy link
Collaborator Author

Uncompressed hex view of the extra two bytes of "alignment" mentioned in #178
2extrabytes

@NikolajSchlej
Copy link
Collaborator Author

NikolajSchlej commented Aug 24, 2022

Turns out that windows-2016 runner is now deprecated for good, and we need to update the Windows CI setup for it to start working again instead of hanging in Queued state forever.

https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/

UPD: this is now fixed and not a concern anymore.

@NikolajSchlej NikolajSchlej merged commit eabd6a8 into new_engine Aug 25, 2022
@NikolajSchlej NikolajSchlej deleted the PR/uncompressed_and_refactorings branch August 25, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UEFITool NE - Extract <file|body> uncompressed
1 participant