-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #13
Update README.md #13
Conversation
I can load and play it just fine on my machine. Specs: Hardware: Base machine: Dell Latitude 5530 CPU: Intel Core i5-1235U RAM size: 16GB Boot drive: 256GB M.2 SSD Software: OS: Ubuntu 22.04 LTS WM: KWin Wayland (KDE 5.24.7) Browser: Firefox Developer Edition 123.0b3 Initial loading time was almost half a minute, clicks in-game are sometimes instantaneous and sometimes take up to three seconds, with the occasional white page with spinner for a second before the page is rendered. Content process RAM usage hovers around 3.3GB, slowly increasing as more pages are loaded, never exceeding 4GB.
Oh no… I just noticed this is PR #13… |
Thank you very much for this detailed feedback @Stehlampe2020, and for this pull request!
That doesn't really sound like "fast nav / ok page render time" 😅 But I'm happy to know that the game now loads in Firefox! Could you maybe rebase this PR and I'll be happy to merge it with the change on the |
Do you mean that by "rebase"? I'm not that experienced with |
There are some explanations there: https://github.com/openedx/edx-platform/wiki/How-to-Rebase-a-Pull-Request I don't think you can do it with GitHub web interface, but don't worry, you can skip that given that it's just a single change. |
Somehow it didn't register my partial revert of the previous commit? Well, here's the change undone in a seperate commit then…
Merged, thanks! |
Just popped up :) |
I can load and play it just fine on my machine in Firefox.
Specs:
Initial loading time was almost half a minute, clicks in-game are sometimes instantaneous and sometimes take up to three seconds, with the occasional white page with spinner for a second before the page is rendered. Content process RAM usage hovers around 3.3GB, slowly increasing as more pages are loaded, never exceeding 4GB.
The pages render without any errors, I just left "visual artifacts" at [x] because you sometimes see a white page with a spinner for a second or two before the page eventually renders.
Here's a screenshot of the game being loaded in Firefox:
By the way, Firefox is in brown and green on the screenshot because of a custom theme which has no impact on functionality at all.