Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #13

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Update README.md #13

merged 3 commits into from
Jan 30, 2024

Conversation

Lampe2020
Copy link
Contributor

@Lampe2020 Lampe2020 commented Jan 28, 2024

I can load and play it just fine on my machine in Firefox.
Specs:

  • Hardware:
    • Base machine: Dell Latitude 5530
    • CPU: Intel Core i5-1235U
    • RAM size: 16GB
    • Boot drive: 256GB M.2 SSD
  • Software:
    • OS: Ubuntu 22.04 LTS
    • WM: KWin Wayland (KDE 5.24.7)
    • Browser: Firefox Developer Edition 123.0b3

Initial loading time was almost half a minute, clicks in-game are sometimes instantaneous and sometimes take up to three seconds, with the occasional white page with spinner for a second before the page is rendered. Content process RAM usage hovers around 3.3GB, slowly increasing as more pages are loaded, never exceeding 4GB.
The pages render without any errors, I just left "visual artifacts" at [x] because you sometimes see a white page with a spinner for a second or two before the page eventually renders.

Here's a screenshot of the game being loaded in Firefox:
Screenshot of Undying Dusk running in Firefox
By the way, Firefox is in brown and green on the screenshot because of a custom theme which has no impact on functionality at all.

I can load and play it just fine on my machine. Specs: 
Hardware: 
    Base machine: Dell Latitude 5530    
    CPU: Intel Core i5-1235U   
    RAM size: 16GB   
    Boot drive: 256GB M.2 SSD   
Software: 
    OS: Ubuntu 22.04 LTS
    WM: KWin Wayland (KDE 5.24.7)
    Browser: Firefox Developer Edition 123.0b3

Initial loading time was almost half a minute, clicks in-game are sometimes instantaneous and sometimes take up to three seconds, with the occasional white page with spinner for a second before the page is rendered.   
Content process RAM usage hovers around 3.3GB, slowly increasing as more pages are loaded, never exceeding 4GB.
@Lampe2020 Lampe2020 changed the title Playing fine on Firefox. Update README.md Jan 28, 2024
@Lampe2020
Copy link
Contributor Author

Oh no… I just noticed this is PR #13

@Lucas-C
Copy link
Owner

Lucas-C commented Jan 30, 2024

Thank you very much for this detailed feedback @Stehlampe2020, and for this pull request!

clicks in-game [...] sometimes take up to three seconds, with the occasional white page with spinner for a second before the page is rendered.

That doesn't really sound like "fast nav / ok page render time" 😅

But I'm happy to know that the game now loads in Firefox!

Could you maybe rebase this PR and I'll be happy to merge it with the change on the can load the game line (but maybe not for the fast nav one)

@Lampe2020
Copy link
Contributor Author

Do you mean that by "rebase"? I'm not that experienced with git and don't know if the GitHub web interface offers that functionality.

@Lucas-C
Copy link
Owner

Lucas-C commented Jan 30, 2024

Do you mean that by "rebase"? I'm not that experienced with git and don't know if the GitHub web interface offers that functionality.

There are some explanations there: https://github.com/openedx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

I don't think you can do it with GitHub web interface, but don't worry, you can skip that given that it's just a single change.
Could you just change that PR to be a single-line edit please? (on the can load the game line)

Somehow it didn't register my partial revert of the previous commit? Well, here's the change undone in a seperate commit then…
@Lucas-C Lucas-C merged commit 87cba2e into Lucas-C:main Jan 30, 2024
@Lampe2020 Lampe2020 deleted the patch-1 branch January 30, 2024 18:34
@Lucas-C
Copy link
Owner

Lucas-C commented Jan 30, 2024

Merged, thanks!

@Lampe2020
Copy link
Contributor Author

Lampe2020 commented Jan 30, 2024

Just popped up :)
Did you see any partial revert in the merge or did it actually not register the partial revert I tried?
[EDIT]: I just realized, I forgot to git push, I'm such a moron…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants