Classic/DllSecur: Specify LOAD_LIBRARY_SEARCH_APPLICATION_DIR. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will debug NanaZipC and try to find a better workaround for that because I'm worried about the security issues of DLL hijacking. Kenji Mouri |
MouriNaruto
added a commit
that referenced
this pull request
Feb 9, 2024
…sue mentioned in #379. (Thanks to dinhngtu.)
|
In the current development stage, I use a hacky way to workaround this issue and make me not worry about the security issues. This hacky workaround I committed will be removed when I finish the split work. The screenshot notes the workaround works because SM3 hashing support implemented in NanaZip.Codecs.dll. Kenji Mouri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NanaZip's codec split causes NanaZipC to fail loading codecs from its application directory.
Specify LOAD_LIBRARY_SEARCH_APPLICATION_DIR to SetDefaultDllDirectories to fix this issue.