Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding serverName option to CreateQUICClient #122

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Adding serverName option to CreateQUICClient #122

merged 1 commit into from
Jul 18, 2024

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Jul 18, 2024 •
edited
Loading

Description

This PR addresses adding a serverName option to CreateQUICClient. When a QUICConnection is established the server name is checked by the server and can reject the connection. We need the ability to set this separately from the Host in some scenarios.

Issues Fixed

Tasks

  • 1. Add serverName option to CreateQUICClient.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Jul 18, 2024
@tegefaulkes tegefaulkes merged commit e1dc351 into staging Jul 18, 2024
4 checks passed
@CMCDragonkai CMCDragonkai mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tegefaulkes tegefaulkes

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server name configuration
1 participant
@tegefaulkes