Fix #610 by not hiding if not visible #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue MyreMylar#610, where calling the hide() method on an already hidden element called the full hide() functionality again, including generating any events, such as unhovering. This bug is present in all hide() method implementation in the codebase (except UIPanel.hide) and is fixed with this commit for all widgets by exiting the hide() method early if self.visible is False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #610, where calling the
hide()method on an already hidden element called the fullhide()functionality again, including generating any events, such as unhovering. This bug is present in allhide()method implementation in the codebase (exceptUIPanel.hide) and is fixed with this commit for all widgets, by exiting thehide()method early ifself.visibleisFalse.