Skip to content

Commit

Permalink
Merge branch 'develop' into update-brick-141
Browse files Browse the repository at this point in the history
  • Loading branch information
gtfierro authored Sep 16, 2024
2 parents c4ca75f + e24d741 commit 00c1110
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
name: continuous integration

on:
push
push:
pull_request_review:
types: [submitted]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -10,6 +12,7 @@ concurrency:
jobs:

styling:
if: github.event_name == 'push'
runs-on: ubuntu-latest
steps:
- name: checkout
Expand All @@ -34,6 +37,7 @@ jobs:
# The "testing" job verifies the base SDK functionality across
# all supported Python versions.
testing:
if: github.event_name == 'push'
needs: styling
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -72,6 +76,7 @@ jobs:
# affect correct operation of notebooks and BACnet scans. Library integration testing
# is a separate job
integration:
if: github.event_name == 'push'
needs: styling
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -110,7 +115,7 @@ jobs:
# These tests detect if changes to ontologies, libraries, models and BuildingMOTIF
# affect correct operation of templates, shapes, and validation
libraries:
needs: styling
if: github.event.review.state == 'approved' || github.ref == 'refs/heads/main' || github.ref == 'refs/heads/develop'
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down
2 changes: 1 addition & 1 deletion notebooks/223P-Validation.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
"source": [
"# create a model to hold an example building from models.open223.info\n",
"lbnl_example_building = Model.create(Namespace(\"urn:lbnl\"))\n",
"lbnl_example_building.graph.parse(\"https://models.open223.info/compiled/lbnl-example.ttl\")"
"lbnl_example_building.graph.parse(\"https://models.open223.info/compiled/lbnl-bdg3-1.ttl\")"
]
},
{
Expand Down

0 comments on commit 00c1110

Please sign in to comment.