Model EV Batteries

[aspeake]

Pull Request Description

Allows a new battery object specific to EVs. Implemented in a way such that it could eventually support bidirectional charging, but not included in this PR.

Companion HPXML PR: hpxmlwg/hpxml#403

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

• Schematron validator (EPvalidator.xml) has been updated
• Sample files have been added/updated (via tasks.rb)
• Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
• Documentation has been updated
• Changelog has been updated
• openstudio tasks.rb update_measures has been run
• No unexpected changes to simulation results of sample files

[shorowit]

@aspeake I assume we will need to add error-checking for multiple batteries? I.e., you can't have two EV batteries, and you can't have one EV battery and one home battery. See here for context. Unless you are trying to address this limitation.

[aspeake]

@aspeake I assume we will need to add error-checking for multiple batteries? I.e., you can't have two EV batteries, and you can't have one EV battery and one home battery. See here for context. Unless you are trying to address this limitation.

Yes, for now we plan to limit to 1 EV/unit. However, the current implementation does allow for one home battery and one EV battery and expects separate schedules for each.

[shorowit]

However, the current implementation does allow for one home battery and one EV battery and expects separate schedules for each.

I assume that probably won't work, for the same reason that modeling two home batteries wasn't previously supported. But we can worry about that later. More of a heads up for now.

[aspeake]

However, the current implementation does allow for one home battery and one EV battery and expects separate schedules for each.

I assume that probably won't work, for the same reason that modeling two home batteries wasn't previously supported. But we can worry about that later. More of a heads up for now.

After some discussions regarding why we do not model two home batteries, I believe it has to do with how we would associate them with an ELCD (PV system). For EVs, I ensure a new ELCD (non-PV) (b1ef026) is created and references the EV battery, so I think it should be possible to include both EVs and home batteries.

[shorowit]

@aspeake You should really run openstudio tasks.rb update_measures so that rubocop can autoformat your code. It also provides a few warnings that you'll want to address.