LDES #406
Open
LDES #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add outputs for PV/wind
hdunham
commented
May 23, 2024
| @@ -43,7 +43,8 @@ function add_general_storage_dispatch_constraints(m, p, b; _n="") | |||
| #Constraint (4j): Dispatch from storage is no greater than power capacity | |||
| @constraint(m, [ts in p.time_steps], | |||
| m[Symbol("dvStoragePower"*_n)][b] >= m[Symbol("dvDischargeFromStorage"*_n)][b, ts] | |||
| ) | |||
| + m[Symbol("dvStorageToGrid")][ts] # TODO: add "b" index to this decision variable | |||
There was a problem hiding this comment.
Either dvStorageToGrid should be included within dvDischargeFromStorage and subtracted out in the load balance equations, or if it's not included like you've done here then dvDischargeFromStorage needs to be renamed to dvStorageToLoad.
hdunham
commented
May 23, 2024
| ) | ||
|
|
||
| #Dispatch from electrical storage is no greater than power capacity |
There was a problem hiding this comment.
why was this constraint added? doesn't seem to do anything beyond what (4l)-alt already accomplishes since it's over time steps without grid
hdunham
commented
May 23, 2024
This reverts commit 970bd2b.
… hardcoded" This reverts commit dcda12a.
This reverts commit 3ce3e32.
This reverts commit e3a7656.
This reverts commit 793e8d7.
This reverts commit 1de9ca6.
This reverts commit 293fcd7.
…rage"" This reverts commit 949bcb8.
This reverts commit b69edbf.
…ne results)" This reverts commit 1d3bce0.
This reverts commit 710f2f5.
This reverts commit 5f2ceb6.
…_load_plus_battery_power)" This reverts commit c9115a5.
This reverts commit 2960b23.
This reverts commit dd13655.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.