Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen defaults #473

Merged
merged 8 commits into from
Jul 11, 2023
Merged

Gen defaults #473

merged 8 commits into from
Jul 11, 2023

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Jul 5, 2023

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

fix

What is the current behavior?

Generator installed_cost_per_kw default was same as v2 default value (500)

What is the new behavior (if this is a feature change)?

Generator installed_cost_per_kw default updated to 650 or 800 if only_runs_during_grid_outage is true

Does this PR introduce a breaking change?

not to the stable endpoints

Other information:

@hdunham hdunham requested a review from Bill-Becker July 5, 2023 22:41
Copy link
Collaborator

@Bill-Becker Bill-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdunham shouldn't these default updates be made in REopt.jl first?

@hdunham hdunham merged commit 18f9560 into develop Jul 11, 2023
1 check passed
@hdunham hdunham deleted the gen-defaults branch July 11, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants