Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/2.1.6 #379

Merged
merged 45 commits into from
Jul 31, 2023
Merged

Release/2.1.6 #379

merged 45 commits into from
Jul 31, 2023

Conversation

mdeceglie
Copy link
Collaborator

@mdeceglie mdeceglie commented Jul 28, 2023 •
edited
Loading

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

dependabot bot and others added 30 commits December 8, 2022 08:42
@dependabot
Bump certifi from 2020.12.5 to 2022.12.7
68318c5 
Bumps [certifi](https://github.com/certifi/python-certifi) from 2020.12.5 to 2022.12.7.
- [Release notes](https://github.com/certifi/python-certifi/releases)
- [Commits](certifi/python-certifi@2020.12.05...2022.12.07)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump ipython from 7.16.3 to 8.10.0 in /docs
c56bffe 
Bumps [ipython](https://github.com/ipython/ipython) from 7.16.3 to 8.10.0.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@7.16.3...8.10.0)

---
updated-dependencies:
- dependency-name: ipython
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@kandersolar
vectorize s-calculation in _mk_test
9d53c38
@kandersolar
use pandas moving average instead of manual
0b10f3e
@kandersolar
Create v2.1.6.rst
8d4a3ae
@kandersolar
use <= and >=
4f0790c
@mdeceglie
avoid NonExistentTimeError in get_clearsky_tamb()
5b296cd
@mdeceglie
add test
ef506cf
@mdeceglie
Add change log
b0d01f6
@mdeceglie
flake8 qa fix
f34e8e9
@kandersolar
increase minimum pandas and numpy versions
f34e1a1
@kandersolar
and statsmodels
34a2760
@kandersolar
and scipy
0248148
@kandersolar @mdeceglie
increase minimum pandas and numpy versions
68ca65b
@kandersolar @mdeceglie
and statsmodels
d3ea994
@kandersolar @mdeceglie
and scipy
8080ad6
@mdeceglie
Merge pull request #371 from NREL/fast-mk
02c68d9 
Improve execution speed of `rdtools.degradation_classical_decomposition`
@mdeceglie
Merge remote-tracking branch 'origin/release/2.1.6' into 372Fix
c4eb49d
@mdeceglie
Add Bernat's name
52f5a5f
@mdeceglie
Merge pull request #373 from NREL/372Fix
1abc8c5 
avoid NonExistentTimeError in get_clearsky_tamb()
@mdeceglie
Merge branch 'master' into dependabot/pip/docs/ipython-8.10.0
4264f23
@mdeceglie
Merge branch 'master' into dependabot/pip/certifi-2022.12.7
7990ca5
@mdeceglie
update jedi
b5c320b
@mdeceglie
update prompt-toolkit
14b60cb
@mdeceglie
update parso
c7794c3
@kandersolar
bump pvlib max to 0.11.0
ecb6e0a
@kandersolar
changelog
c9c8640
@mdeceglie
add pip timeout
de1e416
@mdeceglie
pip fix
e7fb28b
@mdeceglie
Update notebooks
7d9c7cc 
Figure sizes changed, no results were affected
martin-springer
martin-springer approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@martin-springer martin-springer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good to me!

@mdeceglie mdeceglie merged commit 8013982 into master Jul 31, 2023
15 checks passed
@mdeceglie mdeceglie deleted the release/2.1.6 branch July 31, 2023 14:42
@kandersolar
Copy link
Member

I notice that PyPI rejected the automatic wheel upload, seemingly due to the package's version number not being determined correctly (0+untagged.1). Since version numbers are derived from git tags, I guess the issue is that the 2.1.6 tag was not present in the git repo clone used in the distribution build job. It seems that the job checked out the tagged commit, but was not aware of the tag itself. See this line in the 2.1.6 deploy job, compared with the same in the 2.1.5 job.

So I think that's the problem, but I'm not sure how to fix it for future deployments. git pull --tags or similar might be helpful, but I don't know why this would be needed now when it wasn't needed for 2.1.5. The release seems properly associated with the 2.1.6 tag to me. In any case, looks like the 2.1.6 distribution files need to be built and uploaded to PyPI manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandersolar kandersolar kandersolar left review comments

@martin-springer martin-springer martin-springer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdeceglie @kandersolar @martin-springer