Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests #413

Merged
merged 25 commits into from
Jun 27, 2024
Merged

Add missing tests #413

merged 25 commits into from
Jun 27, 2024

Conversation

martin-springer
Copy link
Collaborator

@martin-springer martin-springer commented Apr 29, 2024

This is a draft. Mainly to get Codecov updated.

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.25%. Comparing base (1f25b2f) to head (f2c48cd).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           aggregated_filters_for_trials     #413      +/-   ##
=================================================================
+ Coverage                          71.70%   75.25%   +3.55%     
=================================================================
  Files                                 13       13              
  Lines                               2820     2825       +5     
=================================================================
+ Hits                                2022     2126     +104     
+ Misses                               798      699      -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-springer Thanks for putting this together, a few questions but otherwise looks great.

rdtools/test/energy_from_power_test.py Outdated Show resolved Hide resolved
rdtools/test/filtering_test.py Outdated Show resolved Hide resolved
rdtools/test/irradiance_rescale_test.py Outdated Show resolved Hide resolved
@mdeceglie
Copy link
Collaborator

@martin-springer is it possible to re-trigger the codecov report?

@martin-springer
Copy link
Collaborator Author

martin-springer commented Jun 27, 2024

@martin-springer is it possible to re-trigger the codecov report?

@mdeceglie I do believe so, but haven't done that much myself yet. Looking through the quick start guide (https://docs.codecov.com/docs/quick-start), you can execute the upload of coverage reports from the command line. This page outlines the process (https://docs.codecov.com/docs/codecov-uploader).

We might want to tweak the github action, to not only run when a new PR is created but also when commits are made to a PR. This should then take care of it. I can take a look at how we would need to change the config for that.

@mdeceglie mdeceglie merged commit 8d67b24 into aggregated_filters_for_trials Jun 27, 2024
16 checks passed
@mdeceglie mdeceglie deleted the additional-tests branch June 27, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants