Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign above-grade height for apartment units #1304

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Sep 20, 2024

Pull Request Description

Closes #1303.

Proposal:

  • MF:
    • Top: (n_floors - 1) * ceiling_height
    • Middle: (n_floors - 1) / 2 * ceiling_height
  • All other combinations of building type and level set the height to "auto"; this ensures we use OS-HPXML defaults:
    • Slab: 0 ft
    • Ambient: 2 ft
    • Heated Basement: -7 ft
    • Unheated Basement: 0 ft
    • Vented Crawlspace: 0 ft
    • Unvented Crawlspace: 0 ft

Update BuildExistingModel to register unit height above grade.

image
image

Checklist

Not all may apply:

@shorowit
Copy link
Contributor

shorowit commented Sep 20, 2024

It might be a minor impact, but I'd suggest defaulting to a 2ft belly for mobile homes. That's what OS-HPXML does (see here).

@joseph-robertson
Copy link
Contributor Author

Building ID = 10 (Geometry Stories = 21).
geometry_unit_height_above_grade = 0, 8, ..., 152, 160.

image
image
image

@joseph-robertson
Copy link
Contributor Author

It might be a minor impact, but I'd suggest defaulting to a 2ft belly for mobile homes. That's what OS-HPXML does (see here).

Hmm maybe we were already defaulting to the 2 ft for Mobile Home w/ Ambient foundation type?

@afontani
Copy link
Contributor

After talking a bit with @joseph-robertson, my initial reaction is that the heating energy (natural gas) goes up large enough that I might suggest we assign some value to the argument based on height. I am a little hesitant is that our modeling of large MF buildings is sort of limited right now.

Base automatically changed from latest-os-hpxml to develop September 26, 2024 19:43
@joseph-robertson joseph-robertson added this to the ResStock v3.4.0 milestone Oct 1, 2024
@joseph-robertson joseph-robertson marked this pull request as ready for review October 2, 2024 15:20
@afontani
Copy link
Contributor

afontani commented Oct 2, 2024

@asparke2 : I wanted to let you know that we are considering using a new capability in OS-HPXML for multi-family units that are located above ground level. This would allow us to assign a height of the unit that impacts windspeed and resulting load due to infiltration. This is just to inform you of Multi-Family-related things coming down the pipeline as we plan the Multi-Family work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign above-grade height for apartment units
3 participants