Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#Fixes #100: Update to schema43 #101

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

t-book
Copy link
Contributor

@t-book t-book commented Mar 13, 2024

@alycejenni From my tests this PR covers what is needed to update to the last available schema43 (@ datacite api wrapper). In case I forget something I'm happy about your guidance and working on it.

Overview

https://schema.datacite.org/meta/kernel-4.3/

Changes
Addition of optional “affiliationIdentifier”, “affiliationIdentifierScheme”, and “schemeURI” for affiliation
Addition of optional “schemeURI” for funderIdentifier
Addition of “ROR” to allowed values for funderIdentifierType

Since schema43 affilations can look like

<contributor contributorType="Researcher">
      <contributorName>Huber-Bert, Manfred</contributorName>
      <affiliation affiliationIdentifier="https://ror.org/idkfa3" affiliationIdentifierScheme="ROR" schemeURI="https://ror.org">Something</affiliation>
  </contributor>

Instead of the following with scheme42

<affiliation>Something</affiliation>

Hence, my feature request is to upgrade the plugin to use schema43

Possible Solutions
From my tests it works to just bump to schema43 and use it in later code lines as proposed by the PR

from datacite import DataCiteMDSClient, schema42

@jrdh jrdh requested a review from alycejenni March 27, 2024 14:33
Copy link
Member

@alycejenni alycejenni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! Unfortunately there are a few more changes that are needed before we can merge this:

@alycejenni
Copy link
Member

@t-book you will probably also want to include the changes from #104, making sure you change rightsURI to rightsUri.

@alycejenni alycejenni changed the base branch from main to dev April 25, 2024 10:28
@alycejenni alycejenni self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

2 participants