-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation to GatewayIntents.cs, GatewayClient.cs, ShardedGatewayClient.cs and GatewayOpcodes.cs #20
Conversation
…well as detailed documentation for all intents.
Co-authored-by: Kuba_Z2 <[email protected]>
Fixed the brace |
What about using the |
I thought about it, but I couldn't seem to find any centralized way to reference them all without having to tag random members across NetCord. If it does exist, I'll use it though. (I could also add one) |
To clarify on my last comment, I was referring to newer events such as polls. |
I would remove the polls intents from this pr and move them to #18. |
Sure, moving them after I update the |
|
Added more documentation in the meantime, all events in GatewayClient should be covered now. |
All bullet points converted to XML tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should name guild members as guild users because NetCord's representation of a guild member is the
GuildUser
- I think that all gateway events should have required intents specified.
- Some intents, like
GuildPresences
influence on other behaviours and I think that they should be documented for intents too.
Co-authored-by: Kuba_Z2 <[email protected]>
Co-authored-by: Kuba_Z2 <[email protected]>
Documented pretty much every required intent and its influence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much everything is done now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you replace discord
with Discord
?
Sure, replaced them all. |
Co-authored-by: Kuba_Z2 <[email protected]>
…ateway' in other descriptions.
Instead of being pedantic about it, added the suggestion, but fixed the casing of |
Changed the documentation for it |
We should probably try and finalize this soon |
Added IPartialMessage changes. |
Could you also add xml docs for ShardedGatewayClient? |
Sure |
No description provided.