Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SEO of nav icons #50

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Improve SEO of nav icons #50

merged 2 commits into from
Sep 28, 2024

Conversation

KubaZ2
Copy link
Member

@KubaZ2 KubaZ2 commented Sep 28, 2024

No description provided.

Copy link

The documentation preview is available at https://preview.netcord.dev/50.

Ensured buttons in `renderNavbar` and `themePicker` functions are
explicitly defined as button elements by adding `type="button"`
attributes. This prevents unintended behavior in forms. Also
reordered `@click` and `tooltip` attributes in `nav.ts` for
consistency.
Copy link

The documentation preview is available at https://preview.netcord.dev/50.

@KubaZ2 KubaZ2 merged commit f3164ee into alpha Sep 28, 2024
3 checks passed
@KubaZ2 KubaZ2 deleted the feature/nav-icons-seo branch September 28, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant