Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adopt multi-chain revm #529

Merged
merged 13 commits into from
Jun 25, 2024
Merged

feat: adopt multi-chain revm #529

merged 13 commits into from
Jun 25, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Jun 21, 2024 •
edited
Loading

This PR contains adopts a fork of revm that allows chain-specific configuration, hence the base branch is feat/multichain.

@Wodann Wodann requested a review from agostbiro June 21, 2024 04:44
@Wodann Wodann self-assigned this Jun 21, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6904cd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann had a problem deploying to github-action-benchmark June 21, 2024 04:44 — with GitHub Actions Error
@Wodann Wodann linked an issue Jun 21, 2024 that may be closed by this pull request
Adopt revm with additive optimism feature flag #495
Closed
@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Jun 21, 2024
@Wodann Wodann temporarily deployed to github-action-benchmark June 21, 2024 04:47 — with GitHub Actions Inactive
@Wodann Wodann changed the base branch from main to feat/multichain June 21, 2024 05:55
@Wodann
Copy link
Member Author

Wodann commented Jun 21, 2024

Some error messages changed, causing Hardhat tests to fail. I'll fix those.

@Wodann Wodann temporarily deployed to github-action-benchmark June 21, 2024 16:51 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark June 21, 2024 17:32 — with GitHub Actions Inactive
@Wodann Wodann had a problem deploying to github-action-benchmark June 21, 2024 21:20 — with GitHub Actions Error
@Wodann Wodann temporarily deployed to github-action-benchmark June 21, 2024 21:36 — with GitHub Actions Inactive
agostbiro
agostbiro approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM with some minor comments. Feel free to address them as you see fit before merging.

crates/edr_eth/src/state.rs Show resolved Hide resolved
crates/edr_evm/src/lib.rs Outdated Show resolved Hide resolved
crates/edr_evm/src/runtime.rs Show resolved Hide resolved
@Wodann Wodann had a problem deploying to github-action-benchmark June 24, 2024 18:50 — with GitHub Actions Error
@Wodann Wodann temporarily deployed to github-action-benchmark June 24, 2024 19:05 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark June 25, 2024 15:12 — with GitHub Actions Inactive
@Wodann Wodann merged commit 2ccd443 into feat/multichain Jun 25, 2024
35 checks passed
@Wodann Wodann deleted the refactor/optimism branch June 25, 2024 15:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agostbiro agostbiro agostbiro approved these changes

Assignees

@Wodann Wodann

Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt revm with additive optimism feature flag
2 participants
@Wodann @agostbiro