refactor: decouple Logger and Provider generics

[Wodann]

This change decouples the logger's error type from the provider. This prevents the necessity of knowing the Logger's error type when implementing traits for the provider-related types (errors, data, interval miner, etc.)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 544bfe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[agostbiro]

Thanks, LGTM overall.

As a note, I'm not that big on Box<dyn std::error::Error + Send + Sync>> in libraries due to type erasure, but here the only consumer is the JS interface and there is type erasure anyway due to the FFI, so I don't think it's worth spending time on having richer error type in the logger.

[Wodann]

Thanks, LGTM overall.

As a note, I'm not that big on Box<dyn std::error::Error + Send + Sync>> in libraries due to type erasure, but here the only consumer is the JS interface and there is type erasure anyway due to the FFI, so I don't think it's worth spending time on having richer error type in the logger.

I agree with you that type erasure should be avoided.

With a refactor I did yesterday and an idea I had overnight, there is one alternative approach that I could try to retain the LoggerErrorT. It will be especially beneficial if in Hardhat v3 we allow richer error types to be returned instead of strings.

I'm happy to give that a try now or to create an issue for it. Up to you.

[agostbiro]

I'm ok with it as is

[Wodann]

I created a follow-up issue.