Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update hardhat tests #687

Merged
merged 6 commits into from
Sep 27, 2024
Merged

chore: update hardhat tests #687

merged 6 commits into from
Sep 27, 2024

Conversation

fvictorio
Copy link
Member

Sync hardhat-tests with the latest changes in the Hardhat repository. This also sets up things to change solc's CI to use our repo instead of Hardhat's.

@fvictorio fvictorio requested a review from a team September 27, 2024 08:33
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2024

⚠️ No Changeset found

Latest commit: bbe8ff6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fvictorio fvictorio temporarily deployed to github-action-benchmark September 27, 2024 08:33 — with GitHub Actions Inactive
@fvictorio fvictorio added the no changeset needed This PR doesn't require a changeset label Sep 27, 2024
agostbiro
agostbiro approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@fvictorio fvictorio changed the title Update hardhat tests chore: update hardhat tests Sep 27, 2024
@fvictorio fvictorio added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 4508170 Sep 27, 2024
37 of 38 checks passed
@fvictorio fvictorio deleted the update-hardhat-tests branch September 27, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agostbiro agostbiro agostbiro approved these changes

Assignees
No one assigned
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fvictorio @agostbiro