Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional chain param to viem deploy #783

Open
wants to merge 16 commits into
base: development
Choose a base branch
from

Commits on May 28, 2024

  1. Exclude BNB Test Chain from zero fee configuration in gas fee logic (N…

    …omicFoundation#768)
    
    Also exclude BNB Test chain from the zero fee gas fee logic calculation.
    
    Resolves NomicFoundation#763 
    
    ---------
    
    Co-authored-by: John Kane <[email protected]>
    MukulKolpe and kanej committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1f43a4c View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Configuration menu
    Copy the full SHA
    a1280bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0de73a1 View commit details
    Browse the repository at this point in the history
  3. test: add tests to cover setBalance

    We need two tests, one to cover the standard HH node behaviour and one to cover
    the anvil behaviour of returning a null rather than a boolean.
    kanej committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9d5d7f5 View commit details
    Browse the repository at this point in the history
  4. test: refactor to BuildInfo

    We are attempting to use `any` and testing casting less.
    
    remove superfluous type cast
    kanej authored and zoeyTM committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ccfdcca View commit details
    Browse the repository at this point in the history
  5. Merge pull request NomicFoundation#773 from NomicFoundation/fix/anvil…

    …-create2
    
    Fix: handle anvil `hardhat_setBalance` response for create2
    zoeyTM committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    dbea0f5 View commit details
    Browse the repository at this point in the history
  6. Merge pull request NomicFoundation#772 from NomicFoundation/verify-ci…

    …rcular-imports
    
    Handle circular imports in verify loop
    zoeyTM committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5a6187c View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    eadaa8b View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. update regex

    zoeyTM committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2c34ad9 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. test: tweak to regex

    The Solidity grammar suggests that the first character of an identifier must be
    a letter.
    
    It is arguable therefore, that we should do that for the args list, but I think
    this increment in precision is enough.
    
    See https://docs.soliditylang.org/en/v0.8.26/grammar.html#a4.SolidityLexer.Identifier
    kanej committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4ac475e View commit details
    Browse the repository at this point in the history
  2. Merge pull request NomicFoundation#774 from NomicFoundation/fix/overl…

    …oad-brackets
    
    Adjust regex to handle square brackets
    zoeyTM committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5aa369f View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Configuration menu
    Copy the full SHA
    f897f6c View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge pull request NomicFoundation#776 from NomicFoundation/slack-dms

    Add PR review notifications workflows
    zoeyTM committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    504b615 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Configuration menu
    Copy the full SHA
    86d908b View commit details
    Browse the repository at this point in the history
  2. fix tests

    johnpm-12 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b1511af View commit details
    Browse the repository at this point in the history
  3. fix lint

    johnpm-12 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f0a9619 View commit details
    Browse the repository at this point in the history