Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] l10n_es_aeat_sii_oca: rename method confirm_one_invoice #3165

Merged

Conversation

EmilioPascual
Copy link
Contributor

@EmilioPascual EmilioPascual commented Jul 27, 2023

Debido a que se ha renombrado el método confirm_one_invoice por confirm_one_document añadido en PR: #3088 si había trabajos en colas previos a la modificación se puede bloquear la cola #3088 (review)

@moduon MT-3433

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto, en la migración a v16, se puede quitar ya el método antiguo, y hacer un script de migración en su lugar que renombre la función de los trabajos pendientes.

Hago fast-track para solucionarlo.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-3165-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a67bf8e into OCA:15.0 Jul 27, 2023
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4185832. Thanks a lot for contributing to OCA. ❤️

ljsalvatierra-factorlibre added a commit to factorlibre/l10n-spain that referenced this pull request Jul 28, 2023
ljsalvatierra-factorlibre added a commit to factorlibre/l10n-spain that referenced this pull request Jul 28, 2023
RodrigoBM pushed a commit to factorlibre/l10n-spain that referenced this pull request Sep 4, 2023
RodrigoBM pushed a commit to factorlibre/l10n-spain that referenced this pull request Sep 4, 2023
@EmilioPascual EmilioPascual deleted the 15.0-fix_rename_confirm_one_invoice_method branch January 26, 2024 17:50
manuelregidor pushed a commit to sygel-technology/l10n-spain that referenced this pull request Mar 28, 2024
manuelregidor pushed a commit to sygel-technology/l10n-spain that referenced this pull request May 27, 2024
manuelregidor pushed a commit to sygel-technology/l10n-spain that referenced this pull request Sep 16, 2024
manuelregidor pushed a commit to sygel-technology/l10n-spain that referenced this pull request Sep 17, 2024
manuelregidor pushed a commit to sygel-technology/l10n-spain that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants