Skip to content

Commit

Permalink
Revert "Pin Node.js to v22.6.0" (prettier#16642)
Browse files Browse the repository at this point in the history
  • Loading branch information
fisker authored Sep 27, 2024
1 parent 6168d1e commit 69f4192
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/dev-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ jobs:
- "windows-latest"
node:
# Latest even version
- "22.6.0"
- "22"
# Minimal version for development
- "18"
include:
- os: "ubuntu-latest"
# Pick a version that is fast (normally highest LTS version)
node: "22.6.0"
node: "22"
ENABLE_CODE_COVERAGE: true
FULL_TEST: true
CHECK_TEST_PARSERS: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/prod-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ jobs:
- "windows-latest"
node:
# Latest even version
- "22.6.0"
- "22"
# Minimal version for production
- "14"
include:
- os: "ubuntu-latest"
# Pick a version that is fast (normally highest LTS version)
node: "22.6.0"
node: "22"
FULL_TEST: true
# Versions not tested on linux, normally only even versions
# If latest version is an odd number, it can be listed below too
Expand Down
1 change: 1 addition & 0 deletions cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@
"TSJS",
"typecasted",
"typecheck",
"TYPELESS",
"Ubie",
"Uchino",
"Umidbek",
Expand Down
9 changes: 6 additions & 3 deletions tests/integration/__tests__/config-resolution.js
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,8 @@ test(".js config file", async () => {
"cjs-prettier-config-js-in-type-commonjs",
"cjs-prettier-config-js-in-type-none",
"cjs-prettierrc-js-in-type-commonjs",
"cjs-prettierrc-js-in-type-none",
// Node.js v22.7 throws `MODULE_TYPELESS_PACKAGE_JSON` when `type` missed in package.json
// "cjs-prettierrc-js-in-type-none",
"mjs-prettier-config-js-in-type-module",
"mjs-prettierrc-js-in-type-module",
]) {
Expand All @@ -296,9 +297,11 @@ test(".js config file", async () => {
const mjsError = /Unexpected token 'export'/u;
for (const directoryName of [
"mjs-prettier-config-js-in-type-commonjs",
"mjs-prettier-config-js-in-type-none",
// Node.js v22.7 throws `MODULE_TYPELESS_PACKAGE_JSON` when `type` missed in package.json
// "mjs-prettier-config-js-in-type-none",
"mjs-prettierrc-js-in-type-commonjs",
"mjs-prettierrc-js-in-type-none",
// Node.js v22.7 throws `MODULE_TYPELESS_PACKAGE_JSON` when `type` missed in package.json
// "mjs-prettierrc-js-in-type-none",
]) {
const file = new URL(`./${directoryName}/foo.js`, parentDirectory);
await expect(prettier.resolveConfig(file)).rejects.toThrow(mjsError);
Expand Down

0 comments on commit 69f4192

Please sign in to comment.