This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Update COMMUNITY_GUIDELINES.md #386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added the "Be you" anchor link in the "In short" section at the top of this document * added "<a name="xyz"></a>" code in the "In short" (x 11) and the "On harmful beliefs" (x 1) section headers, to make all the anchor links functional (they don't work for me in their current state) * switched the "Ditch the pornography" and "Keep the content legal" sections of this document, to match their order in the top menu
|
@elaismoreau great your first contribution already 🎊 |
|
On line 162, I would think it would be a bit clearer if there was an asterisk before or after "On harmful beliefs" since there is an asterisk after "Belief" on line 36. |
|
@bardurc I agree, we should add the asterix. @elaismoreau is it possible for you to add this suggestions, everything else looks alright 👍 |
|
I’d like to add that we cannot use html tags on the document, the renderer
on the app don’t support it 😬
…On Fri, 3 May 2019 at 12:21, Shantanu ***@***.***> wrote:
@bardurc <https://github.com/bardurc> I agree, we should add the asterix.
@elaismoreau <https://github.com/elaismoreau> is it possible for you to
add this suggestions, everything else looks alright 👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#386 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADBFXZOLNZ635ABHMIIERLLPTQG3BANCNFSM4HJ3PXYQ>
.
|
@uiboy Thank you! @bardurc Good idea, I've added the asterisk added before "On harmful beliefs". @lifenautjoe Sorry about my HTML tags. Full disclosure, this is my first time with Markdown (and GitHub) :), but not with HTML. I was used to making anchor links that way (either with the name or id attributes), and I had checked to make sure it was applicable with Markdown, as shown here: https://stackoverflow.com/questions/6695439/how-to-link-to-a-named-anchor-in-multimarkdown So if HTML tags can't be used in the app... what should we do about the anchor links? I just tested them, and they still don't work for me; when clicked on from within the document, they do nothing, and when they are accessed from outside the app, they just point at the top of the guidelines page:(. I'm committing the asterisk change to the patch-2 branch, I hope this comment goes after the ones already posted by @shantanu, @bardurc and @lifenautjoe.
elaismoreau
commented
May 3, 2019
There was a problem hiding this comment.
My bad, @uiboy. Wrong ping at the end of my previous comment:) I'm used to type "@ shantanu" .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<a name="xyz"></a>code in the "In short" (x 11) and the "On harmful beliefs" (x 1) section headers, to make all the anchor links functional (they don't work for me in their current state)