Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org: Make newsletters subscripers import more robust. #1527

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cyrillkuettel
Copy link
Contributor

TYPE: Bugfix
LINK: OGC-1829

Checklist

  • I have performed a self-review of my code

Copy link

linear bot commented Sep 23, 2024

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.51%. Comparing base (4c8879f) to head (5d6ea55).

Files with missing lines Patch % Lines
src/onegov/org/forms/newsletter.py 43.75% 9 Missing ⚠️
src/onegov/org/views/subscription.py 75.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/org/views/newsletter.py 95.98% <100.00%> (-0.73%) ⬇️
src/onegov/org/views/subscription.py 89.28% <75.00%> (-3.03%) ⬇️
src/onegov/org/forms/newsletter.py 86.28% <43.75%> (-0.70%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8879f...5d6ea55. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant