Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] - dev_install.py updates #6424

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented May 16, 2024

  1. Why?

    • dev_install.py uses toml which needs to be manually installed in each environment, it's not in the dependency tree
  2. What?

    • Replace it with tomlkit which is used by poetry, thus it's already in the dependency tree
    • Added a Loading... print statement to cli main since the application cold start takes a while and looks hanged
  3. Impact

    • No need to pip install toml anymore, pip install poetry and it will work
  4. Testing Done:

    • python dev_install.py
    • python dev_install.py -e

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels May 16, 2024
@montezdesousa montezdesousa added the do not merge Label to prevent pull request merge label May 16, 2024
cli/pyproject.toml Outdated Show resolved Hide resolved
@montezdesousa montezdesousa requested a review from piiq May 16, 2024 13:01
@montezdesousa montezdesousa removed the do not merge Label to prevent pull request merge label May 16, 2024
Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behaves as intended!

@IgorWounds IgorWounds enabled auto-merge May 16, 2024 16:06
@IgorWounds IgorWounds added this pull request to the merge queue May 16, 2024
Merged via the queue into develop with commit 4c4f57f May 16, 2024
12 checks passed
@IgorWounds IgorWounds deleted the bugfix/dev_install-tomlkit branch May 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants