Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fixes #6688 BLS Title String Concactenation #6690

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[BugFix] Fixes #6688 BLS Title String Concactenation #6690

merged 2 commits into from
Sep 25, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

  2. What?:

    • Error created by concatenating a title string that does not exist.
    • Skips if title is None

  3. Impact:

    • BLS series that do not have catalogue metadata are being handled correctly.

  4. Testing Done:

obb.economy.survey.bls_series("JTS000000000000000QUR")

After:

Screenshot 2024-09-23 at 7 49 08 PM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Sep 24, 2024
@deeleeramone deeleeramone mentioned this pull request Sep 24, 2024
Closed
@IgorWounds IgorWounds added this pull request to the merge queue Sep 25, 2024
Merged via the queue into develop with commit 218ea9a Sep 25, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/bls-empty-series-title branch September 26, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Retrieving BLS series JTS000000000000000QUR leads to an unexpected error
2 participants
@deeleeramone @IgorWounds