-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tip admonition for Wikidata Help:Dates #364
base: master
Are you sure you want to change the base?
Conversation
thadguidry
commented
Aug 19, 2024
- as a result of this issue: Wikidata date upload adds calendar qualifier as URL string instead of entity link OpenRefine#6798
- as a result of this issue: OpenRefine/OpenRefine#6798
✅ Deploy Preview for openrefine-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are only two legal values for calendar, perhaps we can just list them near line 224-224 instead of redirecting the user. The Wikidata pages says:
Currently two calendar models are supported: proleptic Gregorian calendar (Q1985727) and proleptic Julian calendar (Q1985786)
Hi @tfmorris , I thought about that. But there are Phabricator issues for Wikidata where eventually Date datatypes will get more love and also the documentation improved. There's also corner cases and special handling that is covered in their docs. So I'd rather just direct users to read up on the current Date datatypes on Wikidata's official help pages, which are actually quite hard to find just navigating around and often missed. |
It feels weird to me to have a "See also" block at the beginning of the subsection. If it's "see also", it makes more sense to me to have this at the end of this subsection, so that it complements the main content. |