Remove unnecessary role="img" #2704
Open
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hannahiss
changed the title
hannahiss
added
v5
accessibility
docs
hannahiss
changed the title
louismaximepiton
requested changes
Aug 29, 2024
# Conflicts: # site/content/docs/5.3/about/brand.md
hannahiss
commented
Sep 19, 2024
site/content/docs/5.3/migration.md
Outdated
| @@ -23,10 +23,13 @@ toc: true | |||
| #### Buttons | |||
| - <span class="badge text-bg-success">New</span> X social button. | |||
|
|
|||
| #### Orange navbar | |||
There was a problem hiding this comment.
I'm going crazy with all these PRs... This was already done in #2690 here, and in a better way I find... What do you think @julien-deramond
There was a problem hiding this comment.
Anyway, I made some changes:
- fix only
role="img"in this PR Remove unnecessary role="img" #2704 => Change migration guide accordingly - fix only alt attribute in PR Fix a11y audit: alt attribute of decorative images must be empty #2690 => Change migration guide accordingly
hannahiss
added a commit
that referenced
this pull request
Sep 19, 2024
hannahiss
added a commit
that referenced
this pull request
Sep 19, 2024
hannahiss
added a commit
that referenced
this pull request
Sep 19, 2024
|
This branch has conflicts that must be resolved after the recent merges in the main branch |
# Conflicts: # site/content/docs/5.3/dark-mode.md # site/content/docs/5.3/migration.md # site/layouts/shortcodes/orange-global-headers.html # site/layouts/shortcodes/orange-supra.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
#2667
Description
Remove unnecessary role="img" on aria-hidden SVGs or
<img>Motivation & Context
This issue has been seen while fixing a11y audit:
role<img>are used for images only and should not have arole="img"Types of change
Live previews