【Hackathon 7th No.36】为 Paddle 代码转换工具新增 API 转换规则（第 3 组）-part #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
单测未通过，请保证CI通过，CI不通过不予合入： |
|
能否修复下CI看错误，谢谢。 |
…nto hackathon7-part1
|
@zhwesky2010 if self.is_aux_api:
paddle_code = (
textwrap.dedent(
"""
import sys
import importlib
sys.path.append('test_project/utils')
import paddle_aux
paddle_aux=importlib.reload(paddle_aux)
"""
)
+ paddle_code
)
> exec(paddle_code, locals())
> exec(paddle_code, locals())
E File "<string>", line 2
E >>>>>>result = torch.signal.windows.blackman(5)
E ^^
E SyntaxError: invalid syntax
tests/apibase.py:86: SyntaxError |
luotao1
changed the title
|
Code Style不用管，其他需要通过 |
应该是你本地环境不对吧，pip uninstall paconvert 试试，可能跑单测是site-packages环境里的paconvert |
zhwesky2010
reviewed
Sep 29, 2024
| "M", | ||
| "*", | ||
| "center", | ||
| "tau", |
There was a problem hiding this comment.
There was a problem hiding this comment.
恩，经过测试，是需要转写，已开pr改文档。
| ], | ||
| "kwargs_change": { | ||
| "M": "win_length", | ||
| "a": "", |
There was a problem hiding this comment.
文档的转写方式看起来不是直接删除？是否有没对应上的diff？
没对应上的注意回头修正文档
There was a problem hiding this comment.
文档中a需要转写，a传入的是list， paddle组合成了 tuple(str, list)。a作为非可选参数，没有默认值。paddle中没有a这个参数，所以在general_cosine中，a默认为空。从pytorch拿值给a
pytorch:
torch.signal.windows.general_cosine(10, a=[0.46, 0.23, 0.31])paddle:
paddle.audio.functional.get_window(('general_cosine', [0.46, 0.23, 0.31]), 10)| "dtype": "dtype" | ||
| }, | ||
| "paddle_default_kwargs": { | ||
| "dtype": "paddle.float64", |
There was a problem hiding this comment.
paddle中默认float64。已开pr改文档。
def get_window(
window: _WindowLiteral | tuple[_WindowLiteral, float],
win_length: int,
fftbins: bool = True,
dtype: str = 'float64',
) -> Tensor:
def _gaussian(
M: int, std: float, sym: bool = True, dtype: str = 'float64'
) -> Tensor:
def _exponential(
M: int, center=None, tau=1.0, sym: bool = True, dtype: str = 'float64'
) -> Tensor:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
PaddlePaddle/docs#6879
PR APIs