【Hackathon 7th No.37】为 Paddle 代码转换工具新增 API 转换规则（第 4 组） #6884

monster1015 · 2024-09-20T02:54:05Z

No description provided.

monster1015 · 2024-09-21T14:49:49Z

请问这是说我代码风格不对吗？
@luotao1

monster1015 · 2024-09-21T15:21:09Z

@sunzhongkai588

luotao1 · 2024-09-23T05:52:18Z

是的，请根据日志里的提示用precommit修改代码格式。

monster1015 · 2024-09-23T05:53:27Z

是的，请根据日志里的提示用precommit修改代码格式。

好的，请稍等

monster1015 · 2024-09-23T06:53:38Z

已经好了，劳烦review一下

zhwesky2010 · 2024-09-23T07:42:10Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.igamma.md

+### [paddle.gammainc](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/api/paddle/gammainc_cn.html#gammainc)
+
+```python
+paddle.gammainc(x, y, name=None)


paddle也有类方法 paddle.Tensor.gammainc

类方法尽量对应到类方法，实在没有类方法，才对应到非类方法

我在查文档的时候并没有找到对应的方法

我在查文档的时候并没有找到对应的方法

不要查文档，不以文档为准，以代码为准。直接下一个paddle的源码、或者import一个最新版paddle

zhwesky2010 · 2024-09-23T07:42:59Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.igamma_.md

+### [paddle.gammainc_](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/api/paddle/gammainc__cn.html#gammainc)
+
+```python
+paddle.gammainc_(x, y, name=None)


zhwesky2010 · 2024-09-23T07:43:13Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.igammac.md

+### [paddle.gammaincc](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/api/paddle/gammaincc_cn.html#gammaincc)
+
+```python
+paddle.gammaincc(x, y, name=None)


zhwesky2010 · 2024-09-23T07:43:19Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.igammac_.md

+### [paddle.gammaincc\_](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/api/paddle/gammaincc__cn.html#gammaincc)
+
+```python
+paddle.gammaincc_(x, y, name=None)


zhwesky2010 · 2024-09-23T07:47:27Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.matrix_exp.md

+
+| PyTorch | PaddlePaddle | 备注                        |
+| ------- | ------------ | --------------------------- |
+| -       | x            | 输入的方阵，类型为 Tensor。 |


类方法对应到非类方法，不用对比第一个，直接忽略

因此这种不叫参数名不一致

zhwesky2010 · 2024-09-23T07:48:47Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.mvlgamma_.md

+### [paddle.multigammaln_](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/api/paddle/multigammaln__cn.html#multigammaln)
+
+```python
+paddle.multigammaln_(x, p, name=None)


paddle.Tensor.multigammaln_

zhwesky2010 · 2024-09-23T07:49:32Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.orgqr.md

+### [paddle.linalg.householder_product](https://www.paddlepaddle.org.cn/documentation/docs/zh/2.6/api/paddle/linalg/householder_product_cn.html#householder-product)
+
+```python
+paddle.linalg.householder_product(x, tau, name=None)


paddle.Tensor.householder_product

zhwesky2010 · 2024-09-23T07:51:40Z

.../guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.cholesky_ex.md

+### [paddle.linalg.cholesky](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/api/paddle/linalg/cholesky_cn.html)
+
+```python
+paddle.linalg.cholesky(x, upper=False, name=None)


cholesky_ex与cholesky是不是返回值不同，cholesky_ex会多返回一种info类型的

对的，他会多返回一个info

zhwesky2010 · 2024-09-23T07:53:29Z

.../guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.cholesky_ex.md

+| input        | x            | 表示输入参数为多维 Tensor，它的维度应该为 [*, M, N]，其中*为零或更大的批次尺寸，并且最里面的两个维度上的矩阵都应为对称的正定矩阵，仅参数名不一致。 |
+| upper        | upper        | 表示是否返回上三角矩阵或下三角矩阵。                                                                                                                 |
+| check_errors | -            | 是否检查错误，paddle 暂不支持。                                                                                                                       |
+| out          | -            | 表示输出的 Tensor ，Paddle 无此参数，需要转写。                                                                                                      |


如果是返回值不同，应该在下面再加一行：

docs/guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.inv_ex.md

monster1015 · 2024-09-24T01:17:40Z

@zhwesky2010 已经修改好了，PaConvert也已经同步修改了

zhwesky2010

注意参数映射栏：先简述参数功能，再描述差异

zhwesky2010 · 2024-09-24T08:52:33Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.igamma.md

+out = x.igamma(y)
+
+# Paddle 写法
+out = .gammainc(y)


zhwesky2010 · 2024-09-24T08:52:47Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.igamma.md

+
+| PyTorch | PaddlePaddle | 备注          |
+| ------- | ------------ | ------------- |
+| other   | y            | 正参数 Tensor |


加一个仅参数名不同

zhwesky2010 · 2024-09-24T08:52:50Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.igamma_.md

+
+| PyTorch | PaddlePaddle | 备注          |
+| ------- | ------------ | ------------- |
+| other   | y            | 正参数 Tensor |


加一个仅参数名不同，一比一对照模板

zhwesky2010 · 2024-09-24T08:53:10Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.igammac_.md

+
+| PyTorch | PaddlePaddle | 备注          |
+| ------- | ------------ | ------------- |
+| other   | y            | 正参数 Tensor |


一比一对照模板写

zhwesky2010 · 2024-09-24T08:53:37Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.mvlgamma_.md

@@ -0,0 +1,30 @@
+<!--


这些删掉

zhwesky2010 · 2024-09-24T08:54:58Z

docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.ormqr.md

+
+| PyTorch       | PaddlePaddle | 备注                                                   |
+| ------------- | ------------ | ------------------------------------------------------ |
+| input2         | tau         | 仅参数名字不一致 |


先简述下功能，再表明差异

一比一对照模板写

zhwesky2010 · 2024-09-24T08:56:32Z

.../guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.cholesky_ex.md

+
+```python
+# PyTorch 写法
+torch.linalg.cholesky_ex(x, upper=False, out=output)


https://pytorch.org/docs/stable/generated/torch.linalg.cholesky_ex.html#torch.linalg.cholesky_ex

torch的out是两个吧，这个语法上正确吗

zhwesky2010 · 2024-09-24T08:57:10Z

docs/guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.inv_ex.md

+
+```python
+# PyTorch 写法:
+torch.linalg.inv_ex(x, out=y)


zhwesky2010 · 2024-09-24T09:02:19Z

docs/guides/model_convert/convert_from_pytorch/api_difference/torch/torch.ormqr.md

+
+| PyTorch   | PaddlePaddle | 备注                   |
+| --------- | ------------ | ---------------------- |
+| input     | x            | 仅参数名字不一致       |


先简述功能，再描写差异

zhwesky2010 · 2024-09-24T09:02:26Z

docs/guides/model_convert/convert_from_pytorch/api_difference/torch/torch.ormqr.md

+| other     | other        | 一致                   |
+| left      | left         | 一致                   |
+| transpose | transpose    | 一致                   |
+| out       | -            | paddle 无此参数，需转写 |


zhwesky2010 · 2024-09-24T09:07:40Z

后续注意根据文档来实现Matcher，注意不要出现文档与Matcher的diff。

如果实现Matcher的过程中，发现文档有误，需及时更正文档。

monster1015 · 2024-09-25T07:41:19Z

后续注意根据文档来实现Matcher，注意不要出现文档与Matcher的diff。

如果实现Matcher的过程中，发现文档有误，需及时更正文档。

抱歉，写的时候有点着急，不过这次可以了的

zhwesky2010 · 2024-09-27T07:56:39Z

.../guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.cholesky_ex.md

+| ------------ | ------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------- |
+| input        | x            | 表示输入参数为多维 Tensor，它的维度应该为 [*, M, N]，其中*为零或更大的批次尺寸，并且最里面的两个维度上的矩阵都应为对称的正定矩阵，仅参数名不一致。 |
+| upper        | upper        | 表示是否返回上三角矩阵或下三角矩阵。                                                                                                                 |
+| check_errors | -            | 是否检查错误，paddle 暂不支持。                                                                                                                      |


能否转写要备注清楚

zhwesky2010 · 2024-09-27T07:57:10Z

.../guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.cholesky_ex.md

@@ -0,0 +1,49 @@
+## [ torch 参数更多 ]torch.linalg.cholesky_ex


根据分类的优先级排序，这个不能算做 torch参数更多，因为返回参数不同

zhwesky2010 · 2024-09-27T07:57:49Z

.../guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.cholesky_ex.md

+torch.linalg.cholesky_ex(x, upper=False)
+
+# Paddle 写法:
+## 注: 仅支持 check_errors=False 时的情况


check_errors是否支持转写，要在上面写清楚

zhwesky2010 · 2024-09-27T07:58:41Z

docs/guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.inv_ex.md

+| PyTorch      | PaddlePaddle | 备注                                                                  |
+| ------------ | ------------ | --------------------------------------------------------------------- |
+| A            | x            | 输入 Tensor，仅参数名不一致。                                         |
+| check_errors | -            | 是否检查错误，paddle 暂不支持                                         |


是否支持转写，要写清楚

zhwesky2010 · 2024-09-27T07:59:01Z

docs/guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.inv_ex.md

+torch.linalg.inv_ex(x)
+
+# Paddle 写法:
+## 注: 仅支持 check_errors=False 时的情况


check_errors是否支持转写，要写清楚

已经弄好了，单侧也已经好了

luotao1 mentioned this pull request Sep 20, 2024

【Hackathon 7th】开源贡献个人挑战赛 PaddlePaddle/Paddle#68244

Open

luotao1 added the PaddlePaddle Hackathon 飞桨黑客松活动issue与PR label Sep 20, 2024

luotao1 assigned luotao1 and zhwesky2010 Sep 20, 2024

paddle-bot bot added the contributor label Sep 20, 2024

monster1015 force-pushed the NO4 branch 2 times, most recently from c7b79d5 to 315b1d4 Compare September 21, 2024 08:04

monster1015 mentioned this pull request Sep 23, 2024

【Hackathon 7th No.37】为 Paddle 代码转换工具新增 API 转换规则（第 4 组） PaddlePaddle/PaConvert#481

Open

zhwesky2010 reviewed Sep 23, 2024

View reviewed changes

【Hackathon 7th No.37】为 Paddle 代码转换工具新增 API 转换规则（第 4 组）

614e281

monster1015 force-pushed the NO4 branch from 3e0c8cb to 614e281 Compare September 23, 2024 12:35

zhwesky2010 reviewed Sep 24, 2024

View reviewed changes

update

46ac3dc

zhwesky2010 reviewed Sep 27, 2024

View reviewed changes

monster1015 and others added 3 commits October 1, 2024 09:50

Merge branch 'PaddlePaddle:develop' into NO4

a9c013c

update

67a3eed

update

d5980ae

		@@ -0,0 +1,49 @@
		## [ torch 参数更多 ]torch.linalg.cholesky_ex

【Hackathon 7th No.37】为 Paddle 代码转换工具新增 API 转换规则（第 4 组） #6884

Are you sure you want to change the base?

【Hackathon 7th No.37】为 Paddle 代码转换工具新增 API 转换规则（第 4 组） #6884

Conversation

monster1015 commented Sep 20, 2024

monster1015 commented Sep 21, 2024

monster1015 commented Sep 21, 2024

luotao1 commented Sep 23, 2024

monster1015 commented Sep 23, 2024

monster1015 commented Sep 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhwesky2010 Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monster1015 commented Sep 24, 2024

zhwesky2010 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhwesky2010 commented Sep 24, 2024

monster1015 commented Sep 25, 2024

Choose a reason for hiding this comment

zhwesky2010 Sep 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhwesky2010 Sep 24, 2024 •

edited

Loading

zhwesky2010 Sep 27, 2024 •

edited

Loading