[wip] adding loose ordering of rules #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
when updating a large security rule group, one action=move API call is made for each rule of the security rule group, the first rule is placed according to the group position, then each succeeding rule is moved after the previous one. We introduce a **loose** ordering of rules where we only order newly created rules and put them below any other rule of the security group. This considerably reduces the amount of API calls needed to update rules. PaloAltoNetworks/terraform-provider-panos#378
|
there is no CONTRIBUTING document. test and doc can be done in the terraform-provider-panos repo if maintainers are OK with the idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when updating a large security rule group, one action=move API call is made for each rule of the security rule group, the first rule is placed according to the group position, then each succeeding rule is moved after the previous one.
We introduce a loose ordering of rules where we only order newly created rules and put them below any other rule of the security group. This considerably reduces the amount of API calls needed to update rules.
PaloAltoNetworks/terraform-provider-panos#378
How Has This Been Tested?
tested using the matching terraform-provider-panos change (not submitted).
My security group rule contains 900 elements, the overall terraform plan/update (that does much more than just the rules) goes from 1m30s to 1m in local, where there is no communication delay between terraform and the NGFW.
Types of changes
Checklist