-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/scoreboard delegate #11453
base: master
Are you sure you want to change the base?
Fix/scoreboard delegate #11453
Conversation
I don't think you should update the upstream... |
916064d
to
ba3c29b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, if nms/bukkit files are modified FQN should be used instead of imports to reduce the diff. Also, every line that is added needs to be marked with a comment. For more information refer to the CONTRIBUTING.md :)
Don't manually change patch files, you need to make changes, amend it to the latest commit in paper-server and then rebuild patches |
28d9594
to
83d23c8
Compare
…x/scoreboard-delegate # Conflicts: # patches/server/1065-Apply-requested-changes.patch
Fixes #11296