Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/scoreboard delegate #11453

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Intybyte
Copy link

Fixes #11296

@Intybyte Intybyte requested a review from a team as a code owner September 30, 2024 15:29
@masmc05
Copy link
Contributor

masmc05 commented Sep 30, 2024

I don't think you should update the upstream...

Copy link
Contributor

@Leguan16 Leguan16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, if nms/bukkit files are modified FQN should be used instead of imports to reduce the diff. Also, every line that is added needs to be marked with a comment. For more information refer to the CONTRIBUTING.md :)

@masmc05
Copy link
Contributor

masmc05 commented Sep 30, 2024

Don't manually change patch files, you need to make changes, amend it to the latest commit in paper-server and then rebuild patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Changes required
Development

Successfully merging this pull request may close these issues.

Entity#getScoreboardTags directly exposes the Set<String>
5 participants