[UPD] GAS optimisations / DRY

[johnashu]

Gas optimisations and DRY standards.

Remove length from loops

Remove declarations out of loops (except contracts/helpers/TransferHelper.sol - handled here #1261 )

Abstract duplicate code into DRY functions

Better naming for 'items'

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70a457d) 99.77% compared to head (1c61fae) 99.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1268   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          22       22           
  Lines        1363     1363           
  Branches      220      220           
=======================================
  Hits         1360     1360           
  Misses          3        3           

Flag	Coverage Δ
foundry	75.13% <ø> (ø)
production	100.00% <ø> (ø)
reference	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

[johnashu]

@0age Can you trigger the workflow again?

[johnashu]

@0age Is this up for review? Is there anything I need to do?

[ryanio]

i don't see an option to trigger workflow, can you push a fresh commit to see if it shows up? thanks for the PR!

[johnashu]

i don't see an option to trigger workflow, can you push a fresh commit to see if it shows up? thanks for the PR!

Looks like I have a conflict anyhow so let me resolve that!.. It only triggered on my first commit and @0age triggered the last time..

[johnashu]

i don't see an option to trigger workflow, can you push a fresh commit to see if it shows up? thanks for the PR!

I fixed the merge conflicts but it still does not trigger automatically :)

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.