Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extensions for proprietary actors #596

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Use extensions for proprietary actors #596

wants to merge 6 commits into from

Conversation

bclyons12
Copy link
Member

Done here with ActorThermalPlant and ThermalSystemModels as a demonstration

@bclyons12
Copy link
Member Author

Now if you want to use FUSE with ThermalSystemModels, as we've always done, you either have to make your own environment and add or dev both FUSE and ThermalSystemModels into it, or use the FUSE/proprietary_envs/GA environment. For example:

import Pkg; Pkg.activate("FUSE/proprietary_envs/GA")
import FUSE, ThermalSystemModels
dd, ini, act = FUSE.init(:FPP);
FUSE.ActorWholeFacility(dd, act);

@orso82
Copy link
Member

orso82 commented Jul 12, 2024

@bclyons12 could we have a

try
    import ThermalSystemModels
catch
end

in FUSE, to avoid having people to do import FUSE, ThermalSystemModels since they'll be already doing Pkg.activate("FUSE/proprietary_envs/GA")

@bclyons12
Copy link
Member Author

@orso82 ThermalSystemModels is not in the FUSE Project.toml, so I think that will always error.

@bclyons12
Copy link
Member Author

The only way I could think of doing it would be custom packages. So something like:

module FUSE_GA

using FUSE
using ThermalSystemModels

for n in names(FUSE)
    export n
end

Then import FUSE_GA as FUSE will work like before? Maybe? I haven't tested this.

@orso82
Copy link
Member

orso82 commented Jul 12, 2024

I was thinking the same

People can then do using FUSE_GA and get going.

FUSE_GA then must be under FUSE/proprietary_envs/GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants