Neutral fueling actor (WIP) #705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orso82
commented
Sep 10, 2024
| dd = actor.dd | ||
| par = actor.par | ||
|
|
||
| if par.model == :neucg |
There was a problem hiding this comment.
if model is not :neucg this will throw an error
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
| taupin::Entry{Float64} = Entry{Float64}("s", "Particle confinement time"; default=1.0) | ||
| twall::Entry{Float64} = Entry{Float64}("eV", "Wall temperature"; default=10.0) | ||
| vwall::Entry{Float64} = Entry{Float64}("m/s", "Wall particle velocity"; default=100.0) | ||
| model::Switch{Symbol} = Switch{Symbol}([:neucg, :none], "-", "Neutral gas fueling model"; default=:neucg) |
There was a problem hiding this comment.
I think this is a good moment to talk about model = :none
This also happens elsewhere (ActorCoreTransport for example)
As it will show up in the Loggin as if the actor ran but in fact it didn't!
What I think should happen is that these actors shouldnt' be executed and instead use ActorNoOperation in the compound ones (kind of like how we do this for the pedestal)
what do you think @orso82 ?
| end | ||
|
|
||
| cp1d = dd.core_profiles.profiles_1d[] | ||
| resize!(cp1d.neutral, 1)[1] |
There was a problem hiding this comment.
Suggested change
| resize!(cp1d.neutral, 1)[1] | |
| resize!(cp1d.neutral, 1)[1] |
Suggested change
| resize!(cp1d.neutral, 1)[1] | |
| resize!(cp1d.neutral, 1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.