Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A new layer shape has been added named
rectangle_ellipse
. This is a simple version of thedouble_ellipse
shape in which the inboard ellipses have radius = 0, and are therefor right angles instead of curves.In addition to this new shape, the vertical_clearance calculation has been modified so that vertical_clearance is equal to the inboard clearance (instead of an average of the inboard and outboard clearances). This is a more efficient use of vertical space.
Example:
The FPP case with
rectangle_ellipse
blanket, shield, and vacuum vessel looks like this:Unfinished work:
The
optimize_outline
function incx_actor.jl
is not correctly adjusting the height of the TF shapeprinceton_D_scaled
to avoid overlaps with interior layers. As a temporary work-around, the TF coil has been removed from the layers that are optimized byoptimize_outline
. An example of the problem is shown here:Ideally, the
height
of theprinceton_D_scaled
TF shape would be optimized to avoid any overlaps, and to conform to the requestedvertical_clearance
. But for now, excluding the TF layer from this results in a non-optimized TF shape that seems to be ok for this case.