Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer shape development #723

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Layer shape development #723

wants to merge 2 commits into from

Conversation

daveweisberg
Copy link
Contributor

Summary:

A new layer shape has been added named rectangle_ellipse. This is a simple version of the double_ellipse shape in which the inboard ellipses have radius = 0, and are therefor right angles instead of curves.

In addition to this new shape, the vertical_clearance calculation has been modified so that vertical_clearance is equal to the inboard clearance (instead of an average of the inboard and outboard clearances). This is a more efficient use of vertical space.

Example:

The FPP case with rectangle_ellipse blanket, shield, and vacuum vessel looks like this:

Screen Shot 2024-09-30 at 3 15 23 PM

Unfinished work:

The optimize_outline function in cx_actor.jl is not correctly adjusting the height of the TF shape princeton_D_scaled to avoid overlaps with interior layers. As a temporary work-around, the TF coil has been removed from the layers that are optimized by optimize_outline. An example of the problem is shown here:

Screen Shot 2024-09-30 at 3 26 17 PM

Ideally, the height of the princeton_D_scaled TF shape would be optimized to avoid any overlaps, and to conform to the requested vertical_clearance. But for now, excluding the TF layer from this results in a non-optimized TF shape that seems to be ok for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants