Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to release notes #1782

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Add links to release notes #1782

wants to merge 8 commits into from

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented Jul 30, 2024

closes #1538

How do we want these links to appear? Here are some different ways I could add them, but all of these options seem a little heavy-handed and will be hard to properly maintain:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

docs/guides/circuit-library.ipynb Outdated Show resolved Hide resolved
docs/guides/construct-circuits.ipynb Outdated Show resolved Hide resolved
docs/guides/classical-feedforward-and-control-flow.ipynb Outdated Show resolved Hide resolved
## What's required
### What's required
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally a bad practice in "semantic web", which is for accessibility + SEO. You're not supposed to jump from an h1 to h3.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. @javabster asked me to change it to an H3 because the H2 is so big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Add links to release notes to every page in intro paragraph
2 participants