Fix code examples in "Manage Qiskit Serverless compute and data resources" #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the following people are relevant to this code: |
|
PR did deploy, check out the page here: https://docs.quantum.ibm.com/guides/serverless-manage-resources |
Eric-Arellano
approved these changes
Sep 23, 2024
| "@distribute_task(target={\n", | ||
| " \"cpu\": 16,\n", | ||
| " \"mem\": 32 * 1024 * 1024 * 1024\n", | ||
| " \"mem\": 2 * 1024 * 1024 * 1024\n", |
There was a problem hiding this comment.
The prose says:
To allocate 2 GB of memory for your worker, you need to allocate
"mem": 2 * 1024 * 1024 * 1024
As a reader, I was mildly surprised when the code example allocated 32GB rather than 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code examples runnable. Unfortunately we can't add tests just yet (will happen in #1960), but this does mean users will be able to run all the code on the page.
I've removed the section on automatic QPU selection after discussion with the serverless team. This feature is being developed but isn't ready just yet. We'll add the section back in when it's ready.