Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BaseSamplerV1 with explicit version (backport #653) #654

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 2, 2024

This change is motivated by the following warning under the Qiskit 1.2 rc:

DeprecationWarning: The class qiskit.primitives.base.base_sampler.BaseSampler is deprecated as of qiskit 1.2. It will be removed no earlier than 3 months after the release date. The BaseSampler class is a type alias for the BaseSamplerV1 interface that has been deprecated in favor of explicitly versioned interface classes. It is recommended to migrate all implementations to use BaseSamplerV2. However, for implementations incompatible with BaseSamplerV2, BaseSampler can be replaced with the explicitly versioned BaseSamplerV1 class.

Related to #551 and #506.


This is an automatic backport of pull request #653 done by Mergify.

This change is motivated by the following warning:

> DeprecationWarning: The class ``qiskit.primitives.base.base_sampler.BaseSampler``
> is deprecated as of qiskit 1.2. It will be removed no earlier
> than 3 months after the release date. The `BaseSampler` class is
> a type alias for the `BaseSamplerV1` interface that has been
> deprecated in favor of explicitly versioned interface classes.
> It is recommended to migrate all implementations to use
> `BaseSamplerV2`. However, for implementations incompatible with
> `BaseSamplerV2`, `BaseSampler` can be replaced with the explicitly
> versioned `BaseSamplerV1` class.

Related to #551 and #506.

(cherry picked from commit a9bfc91)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10218964818

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.467%

Totals Coverage Status
Change from base Build 9977835165: 0.0%
Covered Lines: 3496
Relevant Lines: 3662

💛 - Coveralls

@garrison garrison merged commit f0f7897 into stable/0.7 Aug 2, 2024
11 checks passed
@garrison garrison deleted the mergify/bp/stable/0.7/pr-653 branch August 2, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants