Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update event stop behavior to exit gracefully. #55

Open
wants to merge 3 commits into
base: amd-staging
Choose a base branch
from

Conversation

harkgill-amd
Copy link
Contributor

Fix for #24

amd-smi event is failing to exit as it waits for all threads to complete before exiting. Each thread has to listen for a maximum of 10 seconds prior to exiting in the current implementation.

  1. Lowered individual listen time for _event_thread allowing for a quicker exit while still capturing all events as it's being looped until the escape sequence is detected.

  2. Added logging for escape character, not sure if needed but helps confirm that key press was registered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant