Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-10236): Edit status in System detail #2107

Merged
merged 1 commit into from
May 30, 2024

Conversation

AsToNlele
Copy link
Contributor

RHINENG-10236

State was ordered in the wrong way
image

How to test:

  1. Go to systems and pick a system that has some CVEs
  2. In the table click the kebab menu and click "Edit status"
  3. There shouldn't be an error

Before:

image

After:

image

@AsToNlele AsToNlele requested a review from a team as a code owner May 21, 2024 12:22
Copy link

jira-linking bot commented May 21, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-10236

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.63%. Comparing base (df3416c) to head (3fd052c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2107      +/-   ##
==========================================
- Coverage   67.58%   66.63%   -0.96%     
==========================================
  Files         131      127       -4     
  Lines        3437     3432       -5     
  Branches     1066     1068       +2     
==========================================
- Hits         2323     2287      -36     
- Misses       1114     1145      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is another problem with the API request to apply the status. When I select some cves and try editing their status, I get error notification that says Danger alert:Couldn’t update status
Select items and update status to try again.

@mkholjuraev
Copy link
Contributor

Also, interesting how your changes solved the first issue :)

@AsToNlele
Copy link
Contributor Author

@mkholjuraev interesting, now I tried but it happened to me only in the CVE detail header, not sure that this is a frontend issue
image

Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I believe your changes are not culprit with the API result.

@AsToNlele AsToNlele merged commit 5f3bc9b into RedHatInsights:master May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants