fix(SystemCVEs): RHINENG-11464 inventory tab advisory filter #2149
+29
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Referenced Jiras: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2149 +/- ##
==========================================
+ Coverage 67.15% 67.18% +0.03%
==========================================
Files 128 128
Lines 3440 3447 +7
Branches 1067 1070 +3
==========================================
+ Hits 2310 2316 +6
- Misses 1130 1131 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bastilian
reviewed
Oct 1, 2024
| @@ -128,9 +128,19 @@ export const SystemCVEs = ({ | |||
| dispatch(changeSystemCVEsParameters(params)); | |||
| }; | |||
|
|
|||
| const paramsWithoutAppname = (params) => | |||
| Object.entries(params).reduce((acc, curr) => { | |||
There was a problem hiding this comment.
It might be better to use .filter here and Object.fromEntries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix default advisory filter in vulnerability in inventory system detail
How to test
Before
After