Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black to 79 chars #49

Closed
wants to merge 1 commit into from
Closed

Black to 79 chars #49

wants to merge 1 commit into from

Conversation

folix-01
Copy link
Member

No description provided.

@folix-01 folix-01 requested review from mamico and cekk July 18, 2023 15:18
@folix-01
Copy link
Member Author

folix-01 commented Jul 18, 2023

Precepts of PEP-8 ʕっ•ᴥ•ʔっ

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5589307795

  • 28 of 76 (36.84%) changed or added relevant lines in 31 files are covered.
  • 9 unchanged lines in 8 files lost coverage.
  • Overall coverage remained the same at 64.699%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/prenotazioni/init.py 2 3 66.67%
src/redturtle/prenotazioni/adapters/conflict.py 0 1 0.0%
src/redturtle/prenotazioni/browser/base.py 1 2 50.0%
src/redturtle/prenotazioni/browser/prenotazione_move.py 1 2 50.0%
src/redturtle/prenotazioni/browser/prenotazioni_portal_state.py 0 1 0.0%
src/redturtle/prenotazioni/content/validators.py 0 1 0.0%
src/redturtle/prenotazioni/events/prenotazione.py 0 1 0.0%
src/redturtle/prenotazioni/events/prenotazioni_folder.py 0 1 0.0%
src/redturtle/prenotazioni/viewlets/app_io.py 0 1 0.0%
src/redturtle/prenotazioni/adapters/slot.py 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
src/redturtle/prenotazioni/adapters/booker.py 1 75.68%
src/redturtle/prenotazioni/adapters/slot.py 1 68.64%
src/redturtle/prenotazioni/browser/prenotazioni_context_state.py 1 78.42%
src/redturtle/prenotazioni/browser/prenotazioni_search.py 1 39.41%
src/redturtle/prenotazioni/content/prenotazione.py 1 60.14%
src/redturtle/prenotazioni/events/prenotazione.py 1 23.08%
src/redturtle/prenotazioni/restapi/services/week_slots/get.py 1 28.57%
src/redturtle/prenotazioni/browser/delete_reservation.py 2 56.1%
Totals Coverage Status
Change from base Build 5466973343: 0.0%
Covered Lines: 2291
Relevant Lines: 3541

💛 - Coveralls

@cekk
Copy link
Member

cekk commented Jul 19, 2023

i don't really like this approach because 79 chars are too few..now we have bigger screens and we follow black rules.

Also restapi don't use this convention: https://github.com/plone/plone.restapi/blob/master/.flake8

@folix-01
Copy link
Member Author

i don't really like this approach because 79 chars are too few..now we have bigger screens and we follow black rules.

Also restapi don't use this convention: https://github.com/plone/plone.restapi/blob/master/.flake8

Screenshot 2023-07-19 at 09 18 14

@folix-01
Copy link
Member Author

i don't really like this approach because 79 chars are too few..now we have bigger screens and we follow black rules.

Also restapi don't use this convention: https://github.com/plone/plone.restapi/blob/master/.flake8

Also every time I see the github diff view of the PR I just want to close the window

@folix-01 folix-01 closed this Jul 19, 2023
@mamico mamico deleted the black_79 branch August 1, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants