Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more assignment tests in docker #261

Merged

Conversation

alexcojocaru2002
Copy link
Contributor

@alexcojocaru2002 alexcojocaru2002 commented Aug 7, 2023

The aim of this MR is to add more random assignment tests (4) in docker, as per discussed in #236

Closes #251

@alexcojocaru2002
Copy link
Contributor Author

Also maybe good to note the docker workflow is a bit flaky, not sure why
Between these 2 runs there is no change
image

@Arraying
Copy link
Contributor

Arraying commented Aug 7, 2023

The GH API sometimes rejects requests with invalid user agents, my guess is the ADD fell back to the default HTTP headers which GitHub was unhappy with. @martinmladenov this way of cache invalidation is very strange, perhaps we should create an issue to improve it. Specifically, ADD supports Git repositories natively, mayhaps we can replace the cache-buster and clone with a singular repository ADD.

@martinmladenov
Copy link
Collaborator

martinmladenov commented Aug 7, 2023

@Arraying Interesting, I didn't know that, thanks. I saw a stackoverflow post which stated that downloading commit info to break the cache is the best solution. Let's make a new issue.

@martinmladenov martinmladenov merged commit caecf35 into SERG-Delft:main May 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run more than one assignment in Docker tests
3 participants