Relax required Kokkos version #20
Conversation
|
Good point! Now that I see this I probably bumped the requirement only for testing purposes in #17. It used to be 3.6.00 (not 3.6.01). Do you think 3.6.00 would still be fine? It might be a good idea to reintroduced the async dispatch check for the older versions (since it was off by default there). What do you think? |
|
3.6.00 would still be fine I think. I specifically picked 3.6.01 because it included a HIP bugfix I need, but that's just my current use-case. Adding the async dispatch flag check probably would not hurt (I forgot about that one). Do you remember for which Kokkos versions we need this check? |
I think that'd be anything less than but not equal to 4.1.0, since 4.1.0 will be the first release with the sender/receiver changes. |
|
@G-071 do you have plans to update this or would you like me to push the remaining changes? |
|
Somewhat related, Kokkos 4.1.00 is now out with the sender/receiver backend. That also includes the change of the |
|
I just now took some time and quickly added the check (sorry for the delay)! Is that one roughly what you had in mind? |
Awesome, yes, that looks good. Thank you! I think that means it's time for a 0.4.0 release 😄 |
I would like to reduce the required Kokkos version to 3.6.01. Particularly, this allows me to use some older ROCm versions on a Jenkins node for automatic performance and verification tests with Octo-Tiger. From what I can see there, at least for AMD GPU builds, the old Kokkos version also works flawlessly with Octo-Tiger and allows me to also run additional tests/comparisons with ROCm 4.5 (instead of just ROCm >= 5).