Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The port of ha-exporter has changed to 9002 and remove superficial if #194

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

MalloZup
Copy link
Contributor

previously it was the hawk-exporter (deprecated)
now the ha-cluster exporter is running on port 9002

@MalloZup MalloZup added the azure label Sep 23, 2019
@MalloZup MalloZup changed the title The port of ha-exporter has changed to 9002 The port of ha-exporter has changed to 9002 and remove superficial if Sep 23, 2019
previously it was the hawk-exporter (deprecated)
now the ha-cluster exporter is running on port 9002
this if is superficial, since this variable is equal to host_ips
the host_ips variable is always set so we don't need to check it.
@stefanotorresi
Copy link
Contributor

@MalloZup is there any way for salt to ensure that the monitored_hosts grain is always present?

@MalloZup
Copy link
Contributor Author

@stefanotorresi we are setting the monitored_hosts every deployment so we assume that it is 100% there each time.
https://github.com/SUSE/ha-sap-terraform-deployments/pull/191/files#diff-d4e4274c023136268670bd8e01283dc2R95

@stefanotorresi
Copy link
Contributor

so if users try to use salt outside terraform, their on their own, right? if that's so, LGTM :)

@MalloZup
Copy link
Contributor Author

(#195) follow-up 🤖

Copy link
Contributor

@ayoub-belarbi ayoub-belarbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoub-belarbi ayoub-belarbi merged commit c4b149a into SUSE:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants