Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEM slight changes #371

Merged
merged 4 commits into from
Jul 3, 2023
Merged

PEM slight changes #371

merged 4 commits into from
Jul 3, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jun 29, 2023 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Rename "Certificate" to "private key" for reducing misunderstanding and accordig with the benchmark category
  • Fix full pattern for value e.g. "-----BEGIN RSA PRIVATE KEY-----"

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Test Benchmark

@babenek babenek marked this pull request as ready for review June 29, 2023 14:22
@babenek babenek requested a review from a team as a code owner June 29, 2023 14:22
@babenek babenek requested a review from csh519 July 3, 2023 06:24
csh519
csh519 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improve PEM Key rule.
Please consider to move PEM_END_PATTERN on next PR.

LGTM 👍

@babenek babenek merged commit d6b96ff into Samsung:main Jul 3, 2023
24 checks passed
@babenek babenek deleted the auxiliary branch July 3, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csh519 csh519 csh519 approved these changes

@kmnls kmnls kmnls approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@Yullia Yullia Awaiting requested review from Yullia

@iuriimet iuriimet Awaiting requested review from iuriimet

@Dmitriy-NK Dmitriy-NK Awaiting requested review from Dmitriy-NK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @csh519 @kmnls