Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntropyValidator #375

Merged
merged 1 commit into from
Jul 5, 2023
Merged

EntropyValidator #375

merged 1 commit into from
Jul 5, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jul 4, 2023 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Refactoring function is_entropy_validate to class.
  • entropy_validation in result is stored value of entropy and iterator

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest

@babenek babenek marked this pull request as ready for review July 4, 2023 15:46
@babenek babenek requested a review from a team as a code owner July 4, 2023 15:46
@babenek babenek marked this pull request as draft July 4, 2023 15:56
@babenek babenek marked this pull request as ready for review July 4, 2023 15:57
csh519
csh519 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refactor entropy validating part.

LGTM 👍

@babenek babenek merged commit 725aed2 into Samsung:main Jul 5, 2023
24 checks passed
@babenek babenek deleted the auxiliary branch July 5, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuriimet iuriimet iuriimet approved these changes

@csh519 csh519 csh519 approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@Yullia Yullia Awaiting requested review from Yullia

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @iuriimet @csh519