Add lower_path to check_exclude_file() for exclude exact file path #376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FilePathExtractor.check_exclude_file()
method has a bug before.The method just convert a
path
to lower case, so when checking the exclude file path, it didn't work properly.I fixed this bug with adding
lower_path
parameter tocheck_exclude_file()
.check_exclude_file()
useslower_path
on pattern matching and usespath
on excluding exact paths and extensions.check_exclude_file()
How has this been tested?